feat: Add CPU options support with nested virtualization#8971
Open
feat: Add CPU options support with nested virtualization#8971
Conversation
- Add CPUOptions struct to EC2NodeClassSpec with coreCount, threadsPerCore, and nestedVirtualization fields - Integrate CPU options into launch template creation pipeline - Add comprehensive validation tests for CPU options - Add integration test for end-to-end CPU options verification - Add documentation and usage examples - Addresses issue aws#8966: Support enabling Nested Virtualization in CPU options
a-nych
reviewed
Feb 24, 2026
- Uncomment NestedVirtualization field in cpuOptions function - Remove comment lines indicating AWS SDK doesn't support it
| // NestedVirtualization: cpuOptions.NestedVirtualization, | ||
| CoreCount: cpuOptions.CoreCount, | ||
| ThreadsPerCore: cpuOptions.ThreadsPerCore, | ||
| NestedVirtualization: cpuOptions.NestedVirtualization, |
There was a problem hiding this comment.
This doesn't seem to compile, need to do something like
if cpuOptions.NestedVirtualization != nil {
opts.NestedVirtualization = ec2types.NestedVirtualizationSpecification(*cpuOptions.NestedVirtualization)
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CPUOptions struct to EC2NodeClassSpec with coreCount, threadsPerCore, and nestedVirtualization fields
Integrate CPU options into launch template creation pipeline
Add comprehensive validation tests for CPU options
Add integration test for end-to-end CPU options verification
Add documentation and usage examples
Addresses issue #8966: Support enabling Nested Virtualization in CPU options
Fixes #8966
Description
This PR adds support for CPU configuration options in EC2NodeClass, specifically addressing the need for nested virtualization support. The implementation includes:
coreCount(1-128),threadsPerCore(1-2), andnestedVirtualization("enabled"|"disabled") fieldsThe feature enables users to specify CPU configurations for EC2 instances, including the requested nested virtualization capability for running virtual machines inside EC2 instances.
How was this change tested?
Unit Tests: Added comprehensive validation tests in pkg/apis/v1/ec2nodeclass_validation_cel_test.go covering:
Integration Tests: Added end-to-end test in test/suites/integration/launch_template_test.go verifying:
Manual Testing: Verified example YAML configuration works correctly with proper validation
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.