Skip to content

Fix deepdiff dependencies #5128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Fix deepdiff dependencies #5128

merged 2 commits into from
Apr 15, 2025

Conversation

pravali96
Copy link
Collaborator

@pravali96 pravali96 commented Apr 14, 2025

Issue #, if available:
Failing model_builder unit test in py3.8 blocking PySDK
https://t.corp.amazon.com/V1741503526/communication

Description of changes:
Pin orderly-set<5.4.0 while using deepdiff>=8.0.0

successful run: deepdiff==8.4.2 with ordered-set==4.1.0, orderly-set==5.3.2, 
failed run: deepdiff==8.4.2 with  ordered-set==4.1.0, orderly-set==5.4.0

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@pravali96 pravali96 marked this pull request as ready for review April 14, 2025 22:43
@pravali96 pravali96 requested a review from a team as a code owner April 14, 2025 22:43
@rsareddy0329 rsareddy0329 merged commit 99b1b81 into aws:master Apr 15, 2025
13 of 14 checks passed
@pravali96 pravali96 deleted the req branch April 15, 2025 16:12
mollyheamazon pushed a commit that referenced this pull request Apr 21, 2025
* Fix deepdiff dependencies

* trigger tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants