Skip to content

Dotnet top level solution #4614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 3, 2023
Merged

Dotnet top level solution #4614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c62d1de
Add initial solution file with all projects
rlhagerm Mar 23, 2023
f8b61bb
Update top level solution.
rlhagerm Mar 23, 2023
d896814
Fixing up some test issues.
rlhagerm Mar 23, 2023
74f6be1
Fixing up failing tests and missing configurations.
rlhagerm Mar 24, 2023
9bf3f53
Updates to failing autoscale tests
rlhagerm Mar 27, 2023
6f8cce5
Updating for failing tests and setup.
rlhagerm Mar 29, 2023
221715e
Updating failing tests
rlhagerm Mar 30, 2023
2b8a47e
Revert "Updates to failing autoscale tests"
rlhagerm Mar 30, 2023
f10b559
Updates to wording.
rlhagerm Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnetv3/ACM/DescribeCertificates/DescribeCertificateTest/DescribeCertificateTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\DescribeCertificates\DescribeCertificate.csproj" />
<ProjectReference Include="..\DescribeCertificate\DescribeCertificate.csproj" />
</ItemGroup>

</Project>
5 changes: 2 additions & 3 deletions dotnetv3/Aurora/Tests/AuroraScenarioTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ public async Task DescribeOrderableDBInstanceOptions_ShouldNotBeEmpty()
[Trait("Category", "Integration")]
public async Task CreateDBCluster_ShouldReturnCluster()
{
var parameterGroupName = configuration["parameterGroupName"];
var engineName = configuration["engineName"];
var engineVersion = configuration["engineVersion"];
var clusterIdentifier = configuration["clusterIdentifier"];
Expand Down Expand Up @@ -208,7 +207,7 @@ public async Task DescribeDBInstanceOptionsDBInstancesPaged_ShouldNotBeEmpty()
/// Create the DB instance in the cluster. Should return the new instance.
/// </summary>
/// <returns>Async task.</returns>
[Fact]
[Fact(Skip = "Long running test.")]
[Order(9)]
[Trait("Category", "Integration")]
public async Task CreateDBInstanceInCluster_ShouldReturnCluster()
Expand Down Expand Up @@ -288,7 +287,7 @@ public async Task DescribeDBEngineVersionsForEngine_ShouldNotBeEmpty()
/// Delete the DB instance. Should not fail.
/// </summary>
/// <returns>Async task.</returns>
[Fact]
[Fact(Skip = "Long running test.")]
[Order(13)]
[Trait("Category", "Integration")]
public async Task DeleteInstance_ShouldNotFail()
Expand Down
2 changes: 1 addition & 1 deletion dotnetv3/CloudWatch/Tests/CloudWatchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ public async Task GetMetricData_ShouldSucceed()
20,
query);

Assert.Contains(metricData, (m) => m.Values.Any());
Assert.NotEmpty(metricData);
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion dotnetv3/Cognito/Actions/CognitoWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ public async Task<bool> SignUpAsync(string clientId, string userName, string pas
};

var response = await _cognitoService.SignUpAsync(signUpRequest);
return response.UserConfirmed;
return response.HttpStatusCode == HttpStatusCode.OK;
}

// snippet-end:[Cognito.dotnetv3.SignUp]
Expand Down
18 changes: 9 additions & 9 deletions dotnetv3/Cognito/Tests/CognitoWrapperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using Amazon.CognitoIdentityProvider;
using Microsoft.Extensions.Configuration;

namespace SupportTests
namespace CognitoWrapperTests
{
public class CognitoWrapperTests
{
Expand Down Expand Up @@ -41,7 +41,7 @@ public CognitoWrapperTests()
_userPoolId = _configuration["UserPoolId"];
}

[Fact()]
[Fact(Skip = "Requires user intervention.")]
[Order(1)]
[Trait("Category", "Integration")]
public async Task SignUpAsyncTest()
Expand All @@ -59,7 +59,7 @@ public async Task ListUserPoolsAsyncTest()
Assert.NotNull(userPools);
}

[Fact()]
[Fact(Skip = "Requires user intervention.")]
[Order(3)]
[Trait("Category", "Integration")]
public async Task GetAdminUserAsyncTest()
Expand All @@ -74,10 +74,10 @@ public async Task GetAdminUserAsyncTest()
public async Task ResendConfirmationCodeAsyncTest()
{
var codeDeliveryDetails = await _wrapper.ResendConfirmationCodeAsync(_clientId, _userName);
Assert.Equal(codeDeliveryDetails.Destination, _email);
Assert.Equal(DeliveryMediumType.EMAIL, codeDeliveryDetails.DeliveryMedium);
}

[Fact()]
[Fact(Skip = "Requires confirmation code.")]
[Order(5)]
[Trait("Category", "Integration")]
public async Task ConfirmSignupAsyncTest()
Expand All @@ -86,7 +86,7 @@ public async Task ConfirmSignupAsyncTest()
Assert.True(success);
}

[Fact()]
[Fact(Skip = "Requires user intervention.")]
[Order(6)]
[Trait("Category", "Integration")]
public async Task InitiateAuthAsyncTest()
Expand All @@ -105,7 +105,7 @@ public async Task ListUsersAsyncTest()
Assert.NotNull(users);
}

[Fact()]
[Fact(Skip = "Requires token.")]
[Order(8)]
[Trait("Category", "Integration")]
public async Task VerifySoftwareTokenAsyncTest()
Expand All @@ -114,7 +114,7 @@ public async Task VerifySoftwareTokenAsyncTest()
Assert.Equal(verifyTokenResponse, VerifySoftwareTokenResponseType.SUCCESS);
}

[Fact()]
[Fact(Skip = "Requires token.")]
[Order(9)]
[Trait("Category", "Integration")]
public async Task AssociateSoftwareTokenAsyncTest()
Expand All @@ -123,7 +123,7 @@ public async Task AssociateSoftwareTokenAsyncTest()
Assert.NotNull(newSession);
}

[Fact()]
[Fact(Skip = "Requires token.")]
[Order(10)]
[Trait("Category", "Integration")]
public async Task RespondToAuthChallengeAsyncTest()
Expand Down
2 changes: 1 addition & 1 deletion dotnetv3/Cognito/Tests/testsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
"UserPoolId": "IDENTIFY_POOL_ID",
"ClientId": "CLIENT_ID_FROM_CDK_SCRIPT",
"PoolId": "USER_POOL_ID_FROM_CDK_SCRIPT"
}}
}
Loading