Provide descriptive error when Simple Replay is ran without audit log being available. #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvbouwel
force-pushed
the
no_audit_log
branch
from
06d5eea to
6192e85
Compare
…lear for all users. This minor change will log a critical error with an explanation why it errors out.
pvbouwel
force-pushed
the
no_audit_log
branch
from
6192e85 to
0917323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Related to #546 (no exact match but other code paths seem to have been taken care of already.
Description of changes:
When no audit log is available an IndexError is thrown which is not clear
for all users. This minor change will explain in a critical message that logs are not available yet and should be enabled and awaited.
Note that this code path is only hit if there is not a single useractivitylog file in the audit prefix. If there is a useractivitylog file then simple replay will correctly identify if there are no records for the provided time range.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.