athena-datalakegen2: Fix Partition Number and Table name for Glue Table API compatibility #2542
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulR3hman
approved these changes
Jan 30, 2025
AbdulR3hman
force-pushed
the
fix/gen2-glue-table-list
branch
from
463de28 to
9c252d1
Compare
auto-merge was automatically disabled
February 13, 2025 09:01
Head branch was pushed to by a user without write access
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2542 +/- ##
============================================
+ Coverage 60.68% 60.71% +0.02%
- Complexity 3871 3872 +1
============================================
Files 593 593
Lines 22130 22130
Branches 2732 2735 +3
============================================
+ Hits 13430 13436 +6
+ Misses 7398 7385 -13
- Partials 1302 1309 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Unable to fetch the table list through the DataLakeGen2 Glue Federated Catalog.
Description of changes:
Lowercased the partition number and removed the toUpperCase() conversion from the table name in the doGetTable method. Please find attached test results for glue and non-glue setup.
gen2-panama-phase2.xlsx
DATALAKEGEN2_FUNCTIONAL_TEST_2025-01-22_14_25_39.358400.csv
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.