Upgraded Arrow to 18 #2576
Merged
Upgraded Arrow to 18 #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulR3hman
force-pushed
the
arrow-upgrade
branch
3 times, most recently
from
8feaed1 to
cad94a7
Compare
AbdulR3hman
commented
Feb 13, 2025
...st/java/com/amazonaws/athena/connectors/clickhouse/ClickHouseMuxJdbcMetadataHandlerTest.java
Outdated
Show resolved
Hide resolved
AbdulR3hman
force-pushed
the
arrow-upgrade
branch
from
6523849 to
f6a57c6
Compare
chngpe
reviewed
Feb 17, 2025
| } | ||
| if (columnType != null && !SupportedTypes.isSupported(columnType)) { | ||
| columnType = Types.MinorType.VARCHAR.getType(); | ||
| if (columnType.isPresent() && !SupportedTypes.isSupported(columnType.get())) { |
There was a problem hiding this comment.
These 2 conditions can be combined
chngpe
reviewed
Feb 17, 2025
| } | ||
|
|
||
| LOGGER.debug("columnType: " + columnType); | ||
| if (columnType != null && SupportedTypes.isSupported(columnType)) { | ||
| schemaBuilder.addField(FieldBuilder.newBuilder(columnName, columnType).build()); | ||
| if (columnType.isPresent() && SupportedTypes.isSupported(columnType.get())) { |
There was a problem hiding this comment.
These 2 conditions can be combined
chngpe
reviewed
Feb 17, 2025
| } | ||
|
|
||
| if (columnType != null && SupportedTypes.isSupported(columnType)) { | ||
| LOGGER.debug("Adding column {} to schema of type {}", columnName, columnType); | ||
| if (columnType.isPresent() && SupportedTypes.isSupported(columnType.get())) { |
There was a problem hiding this comment.
isPresent no really necessary here as 344 will handle
added 7 commits
February 17, 2025 12:48
chngpe
force-pushed
the
arrow-upgrade
branch
from
f6a57c6 to
bff0d07
Compare
|
Discuss with team, refactoring part will comes as a separate PR |
chngpe
approved these changes
Feb 17, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
- Upgraded Arrow to 18 (#2576) - Fixed Encoding Warning (#2595) - Fix codecov format error (#2594) - Update Code Cov on Daily Validation Tests (#2593) - Allow custom glue endpoint to be used (#2587) - Msk connector was throwing null pointer exception when entire record is null, issue fix. (#2588) - Kafka connector was throwing null pointer exception when entire record is null, issue fix. (#2575)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Upgrading to Arrow 18; this will move of from few CVEs as well as bring us closer to the latest version of arrow. requires further testing; release testing, etc.
Description of changes:
Most notable changes are:
Optional; this helps readability and better than null checkinggoogle-big-query; version 15 was coming instead of 18. This requires manual testing ofgoogle-big-queryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.