Support IPv6 endpoint #707
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| #pragma once | ||
| /** | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * SPDX-License-Identifier: Apache-2.0. | ||
| */ | ||
| #include <aws/crt/Exports.h> | ||
|
|
||
| namespace Aws | ||
| { | ||
| namespace Crt | ||
| { | ||
| namespace dns | ||
|
There was a problem hiding this comment. All crt namespaces start with upper case |
||
| { | ||
| AWS_CRT_CPP_API bool IsValidIpV6(const char *host, bool is_uri_encoded); | ||
| } // namespace dns | ||
| } // namespace Crt | ||
| } // namespace Aws | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /** | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * SPDX-License-Identifier: Apache-2.0. | ||
| */ | ||
|
|
||
| #include <aws/common/host_utils.h> | ||
| #include <aws/crt/Types.h> | ||
| #include <aws/crt/dns.h> | ||
|
|
||
| namespace Aws | ||
| { | ||
| namespace Crt | ||
| { | ||
| namespace dns | ||
| { | ||
|
|
||
| bool IsValidIpV6(const char *host, bool is_uri_encoded) | ||
| { | ||
| return aws_host_utils_is_ipv6(Aws::Crt::ByteCursorFromCString(host), is_uri_encoded); | ||
| } | ||
|
|
||
| } // namespace dns | ||
| } // namespace Crt | ||
| } // namespace Aws | ||
|
There was a problem hiding this comment. nit: new line at the end |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably want to put it into DnsUtils.h similar to existign StringUtils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, will change the filename