Skip to content

Remove TODO for tests that are tested in the SDK #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbSteveK merged 5 commits into from
Jun 17, 2025
Merged

Remove TODO for tests that are tested in the SDK #541

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cac9603
Remove TODO for tests that are tested in the SDK
alfred2g Jan 12, 2024
4be4a6c
Merge branch 'main' into remove_todo_test_done
alfred2g Jan 26, 2024
bdcb57c
Merge branch 'main' into remove_todo_test_done
alfred2g Mar 5, 2024
ef5207e
Merge branch 'main' into remove_todo_test_done
alfred2g Apr 20, 2024
c5eca18
Merge branch 'main' into remove_todo_test_done
sbSteveK Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/test_mqtt5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ def test_websocket_connect_tls(self):
client.stop()
callbacks.future_stopped.result(TIMEOUT)

# TODO test_websocket_connect_sigv4 against IoT Core
# test_websocket_connect_sigv4 against IoT Core : tested in the SDK

def test_websocket_connect_http_proxy_tls(self):
input_host_name = _get_env_variable("AWS_TEST_MQTT5_WS_MQTT_TLS_HOST")
Expand Down Expand Up @@ -590,7 +590,7 @@ def test_connect_with_incorrect_basic_authentication_credentials(self):
client.stop()
callbacks.future_stopped.result(TIMEOUT)

# TODO test_websocket_handshake_failure
# test_websocket_handshake_failure : tested in the SDK

def test_double_client_id_failure(self):
input_host_name = _get_env_variable("AWS_TEST_MQTT5_DIRECT_MQTT_HOST")
Expand Down