WIP: Feature/strict posix glob matcher #662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for strict POSIX-compliant glob pattern matching: - Implemented StrictPosixGlobPathMatcher class that follows POSIX standards - Modified S3FileSystem.getPathMatcher to support 'strict-posix-glob:' syntax - Added unit tests for the new matcher implementation - Added integration tests for the S3FileSystem path matcher - Updated README.md with usage examples The strict POSIX matcher provides more predictable behavior for directory boundaries and special character handling compared to the standard glob matcher.
arouel
reviewed
May 1, 2025
|
|
||
| assertThat(matcher.matches(Paths.get("file.txt"))).isTrue(); | ||
| assertThat(matcher.matches(Paths.get("file.csv"))).isFalse(); | ||
| assertThat(matcher.matches(Paths.get("dir/file.txt"))).isFalse(); // Should not match across directories |
There was a problem hiding this comment.
Could be helpful when it fails and also gives context as the comment.
Suggested change
| assertThat(matcher.matches(Paths.get("dir/file.txt"))).isFalse(); // Should not match across directories | |
| assertThat(matcher.matches(Paths.get("dir/file.txt"))).as("Should not match across directories").isFalse(); |
arouel
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
adds support for strict POSIX-compliant glob pattern matching:
The strict POSIX matcher provides more predictable behavior for directory
boundaries and special character handling compared to the standard glob matcher.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.