Add AL2023 launch template task #488
Conversation
| default: "us-west-2" | ||
| description: The region where the cluster is in. | ||
| - name: kubernetes-version | ||
| default: "1.28" |
There was a problem hiding this comment.
let's use the latest k8s version as default please.
There was a problem hiding this comment.
Sure, 1.28 is in the other existing Task FYI.
There was a problem hiding this comment.
Yeah, those are old ones :D, should be updated. Trying to avoid it at least for new ones :D
| params: | ||
| - name: cluster-name | ||
| description: EKS cluster you want to create CFN stack for. | ||
| - name: stack-name |
There was a problem hiding this comment.
I think we can avoid this param and leverage cluster-name ? Usually we try to pass as less params as possible in pipeline def. wdyt ?
There was a problem hiding this comment.
The intention was for this to be a drop-in replacement for the existing LT task, so if this is removed I think it should be done in a later PR
| apiVersion: tekton.dev/v1beta1 | ||
| kind: Task | ||
| metadata: | ||
| name: awscli-eks-cfn-launch-template-al2023 |
There was a problem hiding this comment.
I don't feel too strongly either way, I went this route because I didn't think combining them would actually be much cleaner. We'd need a new parameter to indicate the "type" of ng-cfn-url that was passed, which is kind of clunky. I'd like to actually use this task in a pipeline before I try to fold it into the existing stuff, in case the params need to change, etc.
cartermckinnon
force-pushed
the
al2023-lt-task
branch
from
5313b68 to
1329aa7
Compare
cartermckinnon
force-pushed
the
al2023-lt-task
branch
from
1329aa7 to
ad619a3
Compare
Description of changes:
This adds a task,
awscli-eks-cfn-launch-template-al2023, that creates a launch template compatible with AL2023-based EKS node AMIs.The launch template may be used for a managed nodegroup, with or without an AMI specified, or an unmanaged nodegroup (autoscaling group).
The launch template includes the ability to pass additional options to the
kubelet's config file, via theKubeletConfigparameter.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.