Add neuron-device-plugin load test to the test bed #499
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| {{$uniformQps := DefaultParam .CL2_UNIFORM_QPS 500}} | ||
| {{$neuronResourcesPerPod := DefaultParam .CL2_NEURON_RESOURCES_PER_POD 64}} | ||
| {{$neuronPods := DefaultParam .CL2_NEURON_PODS .Nodes}} | ||
|
|
||
| name: neuron-workers | ||
| namespace: | ||
| number: 1 | ||
| tuningSets: | ||
| - name: UniformQPS | ||
| qpsLoad: | ||
| qps: {{$uniformQps}} | ||
|
|
||
| steps: | ||
| - name: Start measurements | ||
| measurements: | ||
| - Identifier: PodStartupLatency | ||
| Method: PodStartupLatency | ||
| Params: | ||
| action: start | ||
| labelSelector: group = neuron-worker | ||
| threshold: 60s | ||
|
There was a problem hiding this comment. Upstream SLOs is <=5sec. |
||
| - name: Create pods | ||
| phases: | ||
| - namespaceRange: | ||
| min: 1 | ||
| max: 1 | ||
| replicasPerNamespace: {{$neuronPods}} | ||
| tuningSet: UniformQPS | ||
| objectBundle: | ||
| - basename: neuron-worker | ||
| objectTemplatePath: pod.yaml | ||
| templateFillMap: | ||
| Group: neuron-worker | ||
| NeuronResources: {{$neuronResourcesPerPod}} | ||
|
|
||
| - name: Wait for pods to be running | ||
| measurements: | ||
| - Identifier: WaitForRunningPods | ||
| Method: WaitForRunningPods | ||
| Params: | ||
| action: gather | ||
| desiredPodCount: {{$neuronPods}} | ||
| labelSelector: group = neuron-worker | ||
| timeout: 5m | ||
|
|
||
| - name: Measure pod startup latency | ||
| measurements: | ||
| - Identifier: PodStartupLatency | ||
| Method: PodStartupLatency | ||
| Params: | ||
| action: gather | ||
|
|
||
| - name: Delete pods | ||
| phases: | ||
| - namespaceRange: | ||
| min: 1 | ||
| max: 1 | ||
| replicasPerNamespace: 0 | ||
| tuningSet: UniformQPS | ||
| objectBundle: | ||
| - basename: neuron-worker | ||
| objectTemplatePath: pod.yaml | ||
| templateFillMap: | ||
| Group: neuron-worker | ||
| NeuronResources: {{$neuronResourcesPerPod}} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Pod | ||
| metadata: | ||
| generateName: neuron-worker- | ||
| labels: | ||
| group: {{.Group}} | ||
| spec: | ||
| containers: | ||
| - name: main | ||
| image: public.ecr.aws/amazonlinux/amazonlinux:2023 | ||
| command: | ||
| - "sleep" | ||
| - "infinity" | ||
| resources: | ||
| requests: | ||
| aws.amazon.com/neuron: "{{.NeuronResources}}" | ||
shvbsle marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| limits: | ||
| aws.amazon.com/neuron: "{{.NeuronResources}}" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you evaluated if we can leverage https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/testing/scheduler-throughput/config.yaml instead of additional config ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not. I will take a look and get back to you on that one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot directly use that config since the label selectors and default-pod manifest would have to be changed anyway.
I think the current approach of maintaining a separate config for neuron is cleaner and gives us more more control over the load-tests