generated from amazon-archives/__template_Custom
-
Couldn't load subscription status.
- Fork 26
Experiment/dcp save ordering #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IsaevIlya
wants to merge
1
commit into
main
Choose a base branch
from
experiment/dcp-save-ordering
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jet-tong
reviewed
Aug 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the PR with "model.model.layers.1" sort key function, and can confirm that these changes speed up partial checkpoint loading.
8c10ef5 to
9e85202
Compare
…kpoints. Enable custom sorting for tensor/weights when creating checkpoints.
5c5234f to
3440801
Compare
jet-tong
pushed a commit
to jet-tong/s3-connector-for-pytorch
that referenced
this pull request
Sep 29, 2025
…kpoints Cherry-picked prepare_local_plan method from upstream PR awslabs#352. Sequentially loads items based on their actual offset in checkpoint shards, ensuring sequential access patterns and improving I/O efficiency.
1 task
jet-tong
pushed a commit
to jet-tong/s3-connector-for-pytorch
that referenced
this pull request
Oct 6, 2025
…kpoints Cherry-picked prepare_local_plan method from upstream PR awslabs#352. Sequentially loads items based on their actual offset in checkpoint shards, ensuring sequential access patterns and improving I/O efficiency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved Performance for Partial Checkpoint Loading
Background
By default, PyTorch sorts checkpoint data based on size, which distributes tensors/weights randomly across checkpoint shards. While this approach works well with local storage, it can impact performance when working with cloud storage. Currently, PyTorch's checkpoint loading process doesn't follow the same order used during saving, resulting in non-sequential file access patterns.
Changes
1. Sequential Read Optimization
2. Custom Sorting for Partial Loading
Usage Example
If you need to load only model layers that start with "model.model.layers.1", you can group these tensors at the beginning of checkpoint shards:
Results
The resulting checkpoint shard layout will prioritize tensors starting with "model.model.layers.1":
By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.