Conversation
Co-authored-by: HuyHuynh <63286199+huyhuynh3103@users.noreply.github.com>
Co-authored-by: HuyHuynh <63286199+huyhuynh3103@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR back-merges changes into the testnet branch by updating workflow branch naming conventions and removing an unnecessary dependency update step, along with the addition of a new transaction record JSON file for the RNSCommission contract.
- Standardizes branch naming in GitHub workflows by converting single quotes to double quotes.
- Removes the recursive dependency update step from the workflow.
- Adds a JSON file that records transaction details for the RNSCommission contract.
Reviewed Changes
Copilot reviewed 7 out of 19 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| script/operations/bulk-renew.mjs | Introduces a new bulk renewal script with simulation and execution modes. |
| script/operations/bulk-override-renewal-fee.mjs | Adds a script to bulk override renewal fees with simulated and actual execution branches. |
| foundry.toml | Updates EVM version and dependency versions; adds soldeer configuration. |
| .github/workflows/test.yml | Standardizes branch naming and removes the dependency update step. |
Files not reviewed (12)
- broadcast/20241105_UpgradRNSCommissionMainnet.sol/2020/run-1730866136.json: Language not supported
- broadcast/20241105_UpgradRNSCommissionMainnet.sol/2020/run-latest.json: Language not supported
- package.json: Language not supported
- remappings.txt: Language not supported
- script/20241104-upgrade-controller-mainnet/20231104_UpgradeController_Mainnet.s.sol: Language not supported
- script/20241105-upgrade-rnscommission-mainnet /20241105_UpgradRNSCommissionMainnet.sol: Language not supported
- src/RNSCommission.sol: Language not supported
- src/RONRegistrarController.sol: Language not supported
- src/interfaces/IRONRegistrarController.sol: Language not supported
- test/RNSCommission/RNSCommission._allocateCommissionAndTransferToRecipient.t.sol: Language not supported
- test/RONRegistrarController/RONRegistrarController.bulkRenew.t.sol: Language not supported
- test/RONRegistrarController/RONRegistrarController.t.sol: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the GitHub workflow configuration and the addition of a new transaction record. The most important changes include the standardization of branch naming conventions in the workflow file and the removal of a step to update dependencies. Additionally, a new JSON file records a transaction related to the RNSCommission contract.
Updates to GitHub workflow configuration:
.github/workflows/test.yml: Changed branch naming conventions from single quotes to double quotes for consistency..github/workflows/test.yml: Removed the step to recursively update dependencies, simplifying the workflow.Addition of new transaction record:
broadcast/20241105_UpgradRNSCommissionMainnet.sol/2020/run-1730866136.json: Added a new JSON file to record details of a transaction involving the RNSCommission contract, including transaction hash, contract address, and logs.