crypto: Add check isOnCurve for UnmarshalPubkey #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minh-bq
reviewed
Feb 10, 2025
Comment on lines
+175
to
+177
| if !curve.IsOnCurve(x, y) { | ||
| return nil, errInvalidPubkey | ||
| } |
There was a problem hiding this comment.
This is not necessary. We don't have this commit and there is check in elliptic.Unmarshal:https://github.com/golang/go/blob/ff27d270c9f95178f9749bc8e1f15957b1c1d5b3/src/crypto/elliptic/elliptic.go#L171-L173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address report: GHSA-q26p-9cq4-7fc2
Update x/crypto due to vulnerability report: https://pkg.go.dev/vuln/GO-2024-3321