Enable tours mobile carousel #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened as a PR so @lederer can take a look (no need to do a full review). |
|
build again |
3 tasks
flibbertigibbet
force-pushed
the
feature/kak/tours-mobile-carousel#1147
branch
4 times, most recently
from
bc246ca to
1b3a64d
Compare
flibbertigibbet
force-pushed
the
feature/kak/tours-mobile-carousel#1147
branch
from
1b3a64d to
279cc67
Compare
flibbertigibbet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enable tours mobile carousel.
Do not merge: needs styling fixes.Merging for styling afterwards.Demo
Notes
Carousel appears and responds to swipe gestures, but destination cards mostly do not appear, likely due to styling issues.
This PR is based on #1157. I will rebase it ontoursafter #1157 has been merged.Testing Instructions
Closes #1147