Refactored DateTimeTransformer to use narwhals #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limlam96
reviewed
Jan 10, 2025
| **self.to_datetime_kwargs, | ||
| ) | ||
| native_X = X.to_native() | ||
| if isinstance(native_X, pd.DataFrame): |
There was a problem hiding this comment.
narwhals is designed to avoid having to implement branching polars/pandas handling like this, the idea is to make use of narwhals methods, which will translate between pandas/polars behind the scenes. In this case, would try something like
time_unit=self.to_datetime_kwargs.get('time_unit', None)
time_zone=self.to_datetime_kwargs.get('time_zone', None)
df=df.with_columns(nw.col(columns[0]).cast(nw.Datetime(time_unit=time_unit, time_zone=time_zone)))
davidhopkinson26
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently havin one test failing.
