Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump babylon #81

Conversation

gusin13
Copy link
Contributor

@gusin13 gusin13 commented Feb 5, 2025

Bumps babylon, updates wasm files and tests.

@gusin13 gusin13 marked this pull request as ready for review February 9, 2025 13:06
@gusin13
Copy link
Contributor Author

gusin13 commented Feb 9, 2025

@maurolacy Some reward related tests are failing, can you please help debug.
The wasm files and babylon image are built from my PRs but I think you'll get same error if images built from main.

Makefile Outdated Show resolved Hide resolved
contrib/images/babylond/Dockerfile Show resolved Hide resolved
@SebastianElvis
Copy link
Member

The reason why e2e test failed is here: now babylon-contract sends reward back to Babylon only upon the user withdraws rewards, and this only happens if the babylon-contract sets the config that the reward withdrawal destination is Babylon.

For now I agree with @maurolacy -- feel free to comment out the e2e test of reward, as the reward e2e needs some refactoring anyway.

@gusin13 gusin13 force-pushed the 77-refactor-ibc-packet-definitions-to-have-clear-separation-bw-provider-and-consumer branch from e81b5bb to 2f780ad Compare February 10, 2025 09:07
@gusin13
Copy link
Contributor Author

gusin13 commented Feb 11, 2025

closing, in favour of #84

@gusin13 gusin13 closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants