chore: Cleanup eots interfaces #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
force-pushed
the
gai/cleanup-eots-interfaces
branch
from
37d044b to
ec1154d
Compare
gitferry
requested review from
SebastianElvis,
Lazar955,
KonradStaniec and
RafilxTenfen
samricotta
approved these changes
Feb 14, 2025
gitferry
added a commit
that referenced
this pull request
Feb 17, 2025
Patially addressed babylonlabs-io/pm#198 by removing removing `passphrase` from EOTS manager interface and some cleanups. Some notable changes: - Removed `passphrase` parameter from every EOTS manager interface - Removed `KeyRecord` interface as we don't rely on it to create EOTS keys anymore (eotsd keys add instead).
gitferry
added a commit
that referenced
this pull request
Feb 17, 2025
Patially addressed babylonlabs-io/pm#198 by removing removing `passphrase` from EOTS manager interface and some cleanups. Some notable changes: - Removed `passphrase` parameter from every EOTS manager interface - Removed `KeyRecord` interface as we don't rely on it to create EOTS keys anymore (eotsd keys add instead).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patially addressed https://github.com/babylonlabs-io/pm/issues/198 by removing removing
passphrasefrom EOTS manager interface and some cleanups. Some notable changes:passphraseparameter from every EOTS manager interfaceKeyRecordinterface as we don't rely on it to create EOTS keys anymore (eotsd keys add instead).