feat: add Github Actions #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
reviewed
Aug 5, 2024
| NEXT_PUBLIC_DISPLAY_TESTING_MESSAGES=APP_NEXT_PUBLIC_DISPLAY_TESTING_MESSAGES \ | ||
| npm run build | ||
|
|
||
| ARG NEXT_PUBLIC_MEMPOOL_API |
There was a problem hiding this comment.
Do we need to name the args the same way as the env variables? For example, why not just MEMPOOL_API for this one?
There was a problem hiding this comment.
what's the difference with & without next prefix? seems optional for me. the only benefit that i see to make it without prefix is that it turn it into a implementation neutral env variable.
There was a problem hiding this comment.
I used NEXT_PUBLIC_* for ARGS to match with the .env.example for consistency
maiquanghiep
force-pushed
the
hiep/add-github-actions
branch
from
c27af61 to
d6fd426
Compare
vitsalis
reviewed
Aug 5, 2024
.github/workflows/publish.yaml
Outdated
| # - 'main' | ||
| # - 'dev' | ||
| # tags: | ||
| # - '*' |
There was a problem hiding this comment.
Do we need those comments? What's the final form of this section?
.github/workflows/publish.yaml
Outdated
| runs-on: ubuntu-22.04 | ||
| strategy: | ||
| matrix: | ||
| environment: [devnet, staging, mainnet] |
.github/workflows/publish.yaml
Outdated
| runs-on: ubuntu-22.04 | ||
| strategy: | ||
| matrix: | ||
| environment: [devnet, staging, mainnet] |
.github/workflows/publish.yaml
Outdated
| runs-on: ubuntu-22.04 | ||
| strategy: | ||
| matrix: | ||
| environment: [devnet, staging, mainnet] |
maiquanghiep
temporarily deployed
to
mainnet-private
GitHub Actions
Inactive
maiquanghiep
temporarily deployed
to
mainnet-private
GitHub Actions
Inactive
|
I will close this as it's better to merge to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.