Skip to content

Commit

Permalink
fix changelog url
Browse files Browse the repository at this point in the history
Signed-off-by: Vincenzo Scamporlino <[email protected]>
  • Loading branch information
vinzscam committed Feb 4, 2025
1 parent adb4e55 commit 34d77aa
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 9 deletions.
15 changes: 10 additions & 5 deletions src/ReleaseProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,16 @@ export const ReleasesContext = React.createContext<{
isDone: boolean
isLoading: boolean
releases: ReleaseT[]
from?: ReleaseT
to?: ReleaseT
from: ReleaseT
to: ReleaseT
setSelectedVersions: (selectedVersions: any) => void
}>({
isDone: false,
isLoading: false,
releases: [],
setSelectedVersions: () => {},
from: undefined!,
to: undefined!,
})

export const ReleasesProvider = React.memo(function ({
Expand All @@ -31,9 +33,12 @@ export const ReleasesProvider = React.memo(function ({

const value = useFetchReleaseVersions({ packageName, useYarnPlugin })
const [selectedVersions, setSelectedVersions] = useState<{
from?: ReleaseT
to?: ReleaseT
}>({})
from: ReleaseT
to: ReleaseT
}>({
from: { createApp: '', version: '' },
to: { createApp: '', version: '' },
})

return (
<ReleasesContext.Provider
Expand Down
2 changes: 1 addition & 1 deletion src/components/common/UsefulContentSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ class UsefulContentSection extends Component<
getChangelog = ({ version }: { version: string }) => {
const { packageName } = this.props
const { to } = this.context
const { version: toVersion } = to! // TODO: remove the ! when we have a better way to handle this
const { version: toVersion } = to
if (
packageName === PACKAGE_NAMES.RNW ||
packageName === PACKAGE_NAMES.RNM
Expand Down
5 changes: 3 additions & 2 deletions src/components/pages/Home.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import pkg from '../../../package.json'
import { getChangelogURL } from '../../utils'
import { Link } from '../common/Markdown'
import { SettingsProvider } from '../../SettingsProvider'
import { ReleasesProvider } from '../../ReleaseProvider'
import { ReleasesProvider, useReleases } from '../../ReleaseProvider'

const homepage = pkg.homepage

Expand Down Expand Up @@ -326,6 +326,7 @@ const Home = () => {

function BackstageDiffViewer(props: ComponentProps<typeof DiffViewer>) {
const { fromVersion, toVersion } = props as unknown as DiffViewerProps
const { to } = useReleases()

if (fromVersion && fromVersion === toVersion) {
return (
Expand All @@ -339,7 +340,7 @@ function BackstageDiffViewer(props: ComponentProps<typeof DiffViewer>) {
<Link
href={getChangelogURL({
packageName: PACKAGE_NAMES.BACKSTAGE,
version: toVersion,
version: to.version,
})}
target="_blank"
rel="noreferrer"
Expand Down
6 changes: 5 additions & 1 deletion src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,11 @@ export const getChangelogURL = ({
version: string
packageName: string
}) => {
if (packageName === PACKAGE_NAMES.RNW || packageName === PACKAGE_NAMES.RNM) {
if (
packageName === PACKAGE_NAMES.RNW ||
packageName === PACKAGE_NAMES.RNM ||
packageName === PACKAGE_NAMES.BACKSTAGE
) {
return `${RN_CHANGELOG_URLS[packageName]}v${version}`
}

Expand Down

0 comments on commit 34d77aa

Please sign in to comment.