Skip to content

Commit

Permalink
build: update upload-artifact to v4
Browse files Browse the repository at this point in the history
Updates from v3 which is deprecated as of Jan 30, 2025. This requires
uniquely naming the artifacts by including `matrix.generator` in the
name, where necessary.
  • Loading branch information
gm4sl committed Mar 5, 2025
1 parent 11687c6 commit df82666
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ jobs:
run: |
ruby backtrace/save_artifacts.rb --output Crashpad_Linux_build.zip
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: Crashpad_Linux_build_${{ github.sha }}
name: Crashpad_Linux_build_${{ matrix.generator }}_${{ github.sha }}
path: Crashpad_Linux_build.zip

build-windows:
Expand Down Expand Up @@ -106,9 +106,9 @@ jobs:
run: |
ruby backtrace/save_artifacts.rb --output Crashpad_Windows_build.zip
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: Crashpad_Windows_build_${{ github.sha }}
name: Crashpad_Windows_build_${{ matrix.generator }}_${{ github.sha }}
path: Crashpad_Windows_build.zip

build-macos:
Expand Down Expand Up @@ -144,9 +144,9 @@ jobs:
run: |
ruby backtrace/save_artifacts.rb --output Crashpad_MacOs_build_${{ matrix.arch }}.zip
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: Crashpad_MacOs_build_${{ matrix.arch }}_${{ github.sha }}
name: Crashpad_MacOs_build_${{ matrix.arch }}_${{ matrix.generator }}_${{ github.sha }}
path: Crashpad_MacOs_build_${{ matrix.arch }}.zip

build-android:
Expand Down Expand Up @@ -198,7 +198,7 @@ jobs:
run: |
ruby backtrace/save_artifacts.rb --output Crashpad_Android_ndk${{ matrix.ndk }}_apiLevel${{ matrix.apiLevel }}_${{ matrix.abi }}_build.zip
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: Crashpad_Android_ndk${{ matrix.ndk }}_apiLevel${{ matrix.apiLevel }}_${{ matrix.abi }}_build_${{ github.sha }}
path: Crashpad_Android_ndk${{ matrix.ndk }}_apiLevel${{ matrix.apiLevel }}_${{ matrix.abi }}_build.zip

0 comments on commit df82666

Please sign in to comment.