crashpad/android: crash loop detection, guid override #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
approved these changes
May 29, 2024
Factor the appending of additional arguments that are passed to a handler for the crash loop detection and guid override features. These will also be passed to the Java handler used by Android in a later commit. Internal ref BT-2929
While updating backtrace-android to use StartJavaHandlerAtCrash it was noticed that arguments for crash loop detection and guid override were not being passed through to the crashpad handler. This commit adds these arguments in `StartJavaHandlerAtCrash` and have the form: * for crash loop detection: `--annotation=run-uuid=` * for guid override: `--annotation=_backtrace_internal_guid_override=` Internal ref BT-2929
gm4sl
force-pushed
the
gm4sl/BT-2929_android_handler_args
branch
from
cd4da72 to
76e3b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating backtrace-android to use
StartJavaHandlerAtCrashit was noticed that arguments for crash loop detection and guid override were not being passed through to the crashed handler.This commit adds these arguments in
StartJavaHandlerAtCrashto support these features when using this Android-specific mechanism and are of the form:--annotation=run-uuid=--annotation=_backtrace_internal_guid_override=Internal ref BT-2929