crashpad/tests: run only arm64 tests on macOS, skip x86_64 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
requested changes
May 30, 2024
.github/workflows/main.yml
Outdated
| @@ -117,7 +117,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| arch: [arm64, x86_64] | |||
There was a problem hiding this comment.
There is a check below for running tests on specific architecture. We still want to verify building crashpad on x86.
There was a problem hiding this comment.
Updated so that we continue to build for macOS/x64_64. The tests have been disabled as suggested.
Presently, tests run for macOS hang when run as a gitlab job. Disable the x64_64 tests on macOS or now (arm64 were already disabled), until we have time to properly investigate.
gm4sl
force-pushed
the
gmsl/disable_macos_x86_64
branch
from
c4387af to
cc21e4a
Compare
konraddysput
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, tests run for macOS/x64_64 hang when run as a gitlab job. As there is still macOS coverage, as arm64, disable the x64_64 tests on macOS, for now, until we have time to properly investigate.