Add missed file #68 #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gm4sl
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Thanks for finding this.
Referencing https://github.com/backtrace-labs/crashpad/blob/backtrace/util/BUILD.gn it looks like the following files are missing from the CMakeLists.txt for the macOS platform:
- mac/launchd.mm
- mach/child_port_types.h
- mach/task_for_pid.cc
- mach/task_for_pid.h
- misc/capture_context_mac.S
kulchroman
force-pushed
the
add-missed-file
branch
from
76e133e to
ef22d64
Compare
|
Thank you for the complete list! |
gm4sl
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.