Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one part of the jigsaw to get badges/shields#8424 sorted.
The first one is a bit of a silly issue. ScoutCamp doesn't recognise
-----BEGIN PRIVATE KEY-----
as the start of a private key so it falls back to trying to load it from file. This PR loosens the regex.The second one is: Once I got ScoutCamp using the CloudFlare keys, I started hitting this error:
I traced that to this issue: spdy-http2/node-spdy#363
and updating spdy/handle-thing seems to do the trick. As far as I can tell, the only breaking change for spdy 3 --> 4 is dropping older node versions. Node-spdy itself seems to be unmaintaned and there is no changelog, so I had to read the diff.
Everything on this repo is bad and old and unloved so there is no CI, but I've run the tests locally. They all pass. Perhaps more importantly I've run the shields test suite against a copy of shields with this scoutcamp installed into it and they all pass, so that's good.
I probably should have had a look at socket.io while I am working on this repo, but I haven't. It can wait.
Obviously none of us have great detailed insight into this library, but anything else I should think about here?