Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate some services from examples to openApi part 39; affects [maven gradle] #9902

Merged
merged 8 commits into from
Jan 24, 2024
Merged

migrate some services from examples to openApi part 39; affects [maven gradle] #9902

merged 8 commits into from
Jan 24, 2024

Conversation

chris48s
Copy link
Member

Refs #9285

I split this out because it needed some base-service changes to go along with it.

@chris48s chris48s added service-badge New or updated service badge documentation Developer and end-user documentation labels Jan 15, 2024
@chris48s chris48s changed the title migrate some services from examples to openApi; affects [maven gradle] migrate some services from examples to openApi part 39; affects [maven gradle] Jan 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2024 •
edited
Loading

Warnings
⚠️ This PR modified service code for gradle-plugin-portal but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for maven-central but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for maven-metadata but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

Found 'assert' statement added in core/base-service/service-definitions.js.
Please ensure tests are written using Chai expect syntax
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 7257455

PyvesB
PyvesB previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally use proper sentences for parameter docs, aside from that looks good 👍

chris48s and others added 6 commits January 24, 2024 20:20
@chris48s chris48s merged commit 1b91ef5 into badges:master Jan 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB left review comments

Assignees
No one assigned
Labels
documentation Developer and end-user documentation service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris48s @PyvesB