-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate some services from examples to openApi part 44; affects [sonar] #9919
Conversation
I've tried to provide working examples for as many of these as possible, but there are a couple of these where I couldn't find any working example - in those cases, the tests are already mocks so I can't grab one from there and I wasn't able to find any examples in public repos on github. I've just left those with plausible but non-working values. |
component: 'swellaby:azdo-shellcheck', | ||
metric: 'quality_gate', | ||
branch: 'master', | ||
static openApi = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be an alert_status
example?
component: 'org.ow2.petals:petals-se-ase', | ||
metric: 'tech_debt', | ||
branch: 'master', | ||
static openApi = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a sqale_debt_ratio
example?
In both the cases you've flagged the |
Okay, I guess we could implement a route redirector at some point instead! |
There are one or two other services where we do something like this. Here's another example that springs to mind:
I don't really have strong views about replacing with a redirect, but maybe that pattern of calling the param |
Refs #9285
Made a start on this service family. Submitting a WIP PR for now, just to lick the cookie. I'll finish it later in the week.