Skip to content

Playbook-guide update#102

Closed
evilon wants to merge 4 commits intomainfrom
playbook-guide
Closed

Playbook-guide update#102
evilon wants to merge 4 commits intomainfrom
playbook-guide

Conversation

@evilon
Copy link
Copy Markdown
Contributor

@evilon evilon commented Jan 2, 2026

No description provided.

@evilon evilon changed the title Playbook-guide Playbook-guide update Jan 2, 2026
@evilon evilon requested a review from Copilot January 2, 2026 13:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the playbook guide documentation to provide more precise instructions for identifying space-will-be-missing issues in .tsx files. The changes clarify when to flag missing space issues in JSX by specifying two required conditions and explicitly stating when not to flag issues.

  • Refined the criteria for identifying space-will-be-missing issues with a two-condition check
  • Added explicit exceptions to avoid false positives when spaces are already present

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@evilon
Copy link
Copy Markdown
Contributor Author

evilon commented Jan 2, 2026

The build issue sounds familiar:

Error: The action actions/upload-artifact@v4 is not allowed in badrap/docs.badrap.io because all actions must be from a repository owned by badrap, created by GitHub, verified in the GitHub Marketplace, or match one of the patterns: changesets/action@, docker/, google-github-actions/, hashicorp/setup-terraform@, pnpm/action-setup@, tailscale/github-action@. All actions must also be pinned to a full-length commit SHA

@evilon evilon requested a review from jukkakoskinen January 2, 2026 13:22
evilon and others added 3 commits January 2, 2026 17:47
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@evilon evilon marked this pull request as draft January 2, 2026 16:00
@evilon evilon closed this Jan 2, 2026
@evilon evilon deleted the playbook-guide branch January 2, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants