Proposed behaviour for bug #457 #508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is basically what Twitter does with its "cards" (Flic.kr links remain but the card shows the image). The only issue so far is if someone uses IFTTT or similar to auto- post Flickr photos. IFTTT puts the Flickr URL in *and* uploads the photo to Twitter, which results in us seeing it twice.
This compromise means we don't see different images when a user links to one image and uploads a different one (we only see the upload) BUT it means that we don't get duplicate images (which are common when a user has used something like IFTT to auto-post photos from Flickr - it uploads the image AND links to it on Flickr, so we could end up loading it twice because of our 3rd part image support)
|
Superseded by #612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my proposed fix for bug #457. It only removes Twitter links (because that's what Twitter does) and it prioritises Twitter media over external links and only loads 3rd party images if there is no Twitter media (because that's what Twitter does - see https://twitter.com/YorksWildlife/status/693132495122989056, which links to Flickr but has a Twitter image, not a Flickr card).
I think this balances the problem of removing URLs from the middle of tweets (especially when Flickr images are web pages with comments, etc) against the problem of duplicating images, while still loading plenty of media.