Use latest version and fix release file name in Dockerfile.template #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drskullster
force-pushed
the
drskullster/fix-release-name-in-dockerfile
branch
from
aba810b to
28c91c7
Compare
rahul-thakoor
force-pushed
the
drskullster/fix-release-name-in-dockerfile
branch
3 times, most recently
from
55c2827 to
0aa806e
Compare
drskullster
force-pushed
the
drskullster/fix-release-name-in-dockerfile
branch
from
f4c09b3 to
2d4a18a
Compare
rahul-thakoor
force-pushed
the
drskullster/fix-release-name-in-dockerfile
branch
15 times, most recently
from
d02fb7f to
0b9e419
Compare
Change-type: patch Co-authored-by: drskullster <[email protected]> Signed-off-by: Rahul Thakoor <[email protected]>
We currently define the pre-build commands to run individually for each target. All the commands are same, and we do not run target specific commands. This commit defines the pre-build commands using the [build config](https://github.com/cross-rs/cross/wiki/Configuration#build) Signed-off-by: Rahul Thakoor <[email protected]>
rahul-thakoor
force-pushed
the
drskullster/fix-release-name-in-dockerfile
branch
from
0b9e419 to
c0eb92d
Compare
rahul-thakoor
changed the title
pipex
reviewed
Apr 24, 2024
| BINARY_ARCH_NAME="aarch64-unknown-linux-gnu" ;; \ | ||
| "amd64") \ | ||
| BINARY_ARCH_NAME="x86_64-unknown-linux-gnu" ;;\ | ||
| "armv7hf") \ |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch