Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix always add native wrapped gas infor to the token objects #624

Conversation

NIXBNT
Copy link
Collaborator

@NIXBNT NIXBNT commented May 6, 2024

No description provided.

@NIXBNT NIXBNT added the enhancement New feature or request label May 6, 2024
@NIXBNT NIXBNT requested a review from barakman May 6, 2024 14:21
@NIXBNT NIXBNT added the bug Something isn't working label May 6, 2024
@NIXBNT
Copy link
Collaborator Author

NIXBNT commented May 7, 2024

Handles related issue #626

@barakman barakman force-pushed the 592-wgas-token-not-in-flashloan-tokens-can-cause-flashloan-critical-error-for-other-flashloan-tokens branch from 78b6802 to 2906ca5 Compare May 7, 2024 12:37
@platonfloria platonfloria force-pushed the 592-wgas-token-not-in-flashloan-tokens-can-cause-flashloan-critical-error-for-other-flashloan-tokens branch from 2906ca5 to 48be83b Compare May 7, 2024 18:46
@@ -48,6 +48,7 @@
set_network_to_mainnet_if_replay,
set_network_to_tenderly_if_replay,
handle_target_token_addresses,
verify_min_bnt_is_respected,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used

@@ -1716,6 +1716,27 @@ def handle_target_token_addresses(static_pool_data: pd.DataFrame, target_tokens:
return target_token_addresses


def verify_min_bnt_is_respected(bot: CarbonBot, mgr: Any):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced this PR with #632 since some merge mistakes were made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants