Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tunnel] implement route - router #495

Open
wants to merge 26 commits into
base: tunnel-ibc-hook
Choose a base branch
from
Open

[Tunnel] implement route - router #495

wants to merge 26 commits into from

Conversation

satawatnack
Copy link
Member

@satawatnack satawatnack commented Nov 27, 2024 •
edited
Loading

Implementation details

  • Add router route

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@satawatnack satawatnack requested a review from RogerKSI November 27, 2024 11:01
@RogerKSI RogerKSI changed the title [Tunnel] Add Router route [Tunnel] implement route - router Jan 9, 2025
@satawatnack satawatnack changed the base branch from master to tunnel-ibc-hook January 27, 2025 09:24
@satawatnack satawatnack marked this pull request as ready for review January 27, 2025 09:59
RogerKSI
RogerKSI requested changes Feb 4, 2025
View reviewed changes
scripts/tunnel/create_router_tunnel.sh Outdated Show resolved Hide resolved
x/tunnel/types/params.go Outdated Show resolved Hide resolved
proto/band/tunnel/v1beta1/route.proto Outdated Show resolved Hide resolved
x/tunnel/client/cli/tx.go Outdated Show resolved Hide resolved
x/tunnel/keeper/msg_server.go Outdated Show resolved Hide resolved
@satawatnack satawatnack requested a review from RogerKSI February 10, 2025 03:52
RogerKSI
RogerKSI reviewed Feb 14, 2025
View reviewed changes
x/tunnel/types/params.go Outdated Show resolved Hide resolved
proto/band/tunnel/v1beta1/route.proto
Comment on lines +90 to +93
// destination_gas_limit is the destination gas limit
uint64 destination_gas_limit = 3;
// destination_gas_price is the destination gas price
uint64 destination_gas_price = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove these 2 fields? seems hard for user to specify

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for router intregation contract support autogas

@satawatnack satawatnack requested a review from RogerKSI February 14, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkitlabs nkitlabs nkitlabs approved these changes

@taobun taobun Awaiting requested review from taobun

@colmazia colmazia Awaiting requested review from colmazia

@RogerKSI RogerKSI Awaiting requested review from RogerKSI

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satawatnack @RogerKSI @nkitlabs