Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.1.x compatibility #25

Merged
merged 3 commits into from
Jun 29, 2014
Merged

Ruby 2.1.x compatibility #25

merged 3 commits into from
Jun 29, 2014

Conversation

gilles-leblanc
Copy link
Contributor

This is a fix for issue #22.

It includes the two commits from @spooner 's #23 pull request (keeping his original commits to give credit where credit is due) plus an additional commit to fix the remaining problem.

I have tested this with Ruby 2.0.0-p247, 2.1.0 and 2.1.2.

Merging this would also allow to close #23 and #24 which would now be redundant.

I have updated the CHANGELOG and version number but I didn't rebuild the gem. I am not sure if I had to do this or how to update the gem so RubyGems is aware of this new version. If I am given instructions I can do this as well or leave this to the texplay maintainers.

Thanks,
I remain available for any further work needed on this pull request.

bil-bas and others added 3 commits June 29, 2014 14:37
shawn42 added a commit that referenced this pull request Jun 29, 2014
@shawn42 shawn42 merged commit e6e0e8d into banister:master Jun 29, 2014
@gilles-leblanc
Copy link
Contributor Author

@shawn42 How do we update the official ruby gem?

@shawn42
Copy link
Collaborator

shawn42 commented Jun 29, 2014

I will release a pre version tonight for you to verify. I'll post here
when I get the gem pushed.
On Jun 29, 2014 4:03 PM, "Gilles Leblanc" [email protected] wrote:

@shawn42 https://github.com/shawn42 How do we update the official ruby
gem?


Reply to this email directly or view it on GitHub
#25 (comment).

@gilles-leblanc
Copy link
Contributor Author

Great thanks.
On Jun 29, 2014 5:21 PM, "Shawn Anderson" [email protected] wrote:

I will release a pre version tonight for you to verify. I'll post here
when I get the gem pushed.
On Jun 29, 2014 4:03 PM, "Gilles Leblanc" [email protected]
wrote:

@shawn42 https://github.com/shawn42 How do we update the official
ruby
gem?


Reply to this email directly or view it on GitHub
#25 (comment).


Reply to this email directly or view it on GitHub
#25 (comment).

@shawn42
Copy link
Collaborator

shawn42 commented Jun 30, 2014

@gilles-leblanc I've pushed the pre build, you should be able to specify by gem installing with --pre or specify the full version number in your Gemfile. I have not pushed the windows build yet. I need to investigate what it takes to build that first.

@gilles-leblanc
Copy link
Contributor Author

@shawn42 I have just tested under Linux with my https://github.com/gilles-leblanc/gameproject. I tried something using texplay under 2.0.0. Changed to ruby 2.1.2. saw that it failed because of texplay. Did gem install texplay --pre. Tried again and it worked.

@shawn42
Copy link
Collaborator

shawn42 commented Jul 1, 2014

@banister do you have any advice for building texplay on windows?
Here's my compile error:
https://gist.github.com/shawn42/a1a591d813afcc15f02c

Should I be using rake-compiler or some such?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants