-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 2.1.x compatibility #25
Conversation
Changes KLASS_OF macro which wasn't compatible with the new Ruby version. Fixes #22
@shawn42 How do we update the official ruby gem? |
I will release a pre version tonight for you to verify. I'll post here
|
Great thanks.
|
@gilles-leblanc I've pushed the pre build, you should be able to specify by gem installing with --pre or specify the full version number in your Gemfile. I have not pushed the windows build yet. I need to investigate what it takes to build that first. |
@shawn42 I have just tested under Linux with my https://github.com/gilles-leblanc/gameproject. I tried something using texplay under 2.0.0. Changed to ruby 2.1.2. saw that it failed because of texplay. Did gem install texplay --pre. Tried again and it worked. |
@banister do you have any advice for building texplay on windows? Should I be using rake-compiler or some such? |
This is a fix for issue #22.
It includes the two commits from @spooner 's #23 pull request (keeping his original commits to give credit where credit is due) plus an additional commit to fix the remaining problem.
I have tested this with Ruby 2.0.0-p247, 2.1.0 and 2.1.2.
Merging this would also allow to close #23 and #24 which would now be redundant.
I have updated the CHANGELOG and version number but I didn't rebuild the gem. I am not sure if I had to do this or how to update the gem so RubyGems is aware of this new version. If I am given instructions I can do this as well or leave this to the texplay maintainers.
Thanks,
I remain available for any further work needed on this pull request.