Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename useProvenWithdrawal hook and correct Synapse image URL #1682

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MarsonKotovi4
Copy link

What changed? Why?

  • Renamed the export from useprovenWithdrawal to useProvenWithdrawal for consistency.
  • Updated all references in useWithdrawalStatus.ts to match the new name.
  • Corrected a typo in ecosystem.json by changing the image URL from /images/partners/synpase.webp to /images/partners/synapse.webp.

Notes to reviewers

  • Please verify the hook name now follows the project’s naming conventions.
  • Double-check that the updated image path is valid and displays correctly.

How has it been tested?

  • Ran a local build to ensure no compile errors.
  • Confirmed the hook usage in the withdrawal flow works as expected.
  • Verified the updated image path renders without errors.

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:37pm

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Jan 31, 2025

@MarsonKotovi4 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@MarsonKotovi4
Copy link
Author

@cb-heimdall

@MarsonKotovi4
Copy link
Author

@ryandotsmith

@wbnns wbnns added the base web review To be reviewed by the Base web team label Feb 5, 2025
@wbnns
Copy link
Member

wbnns commented Feb 5, 2025

@MarsonKotovi4 Thanks! The Synapse image was fixed in #1702 🙏

@MarsonKotovi4
Copy link
Author

@wbnns ok! fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base web review To be reviewed by the Base web team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants