fix(pypi): fixes to the marker evaluation and utils #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are just bugfixes to already merged code: * Fix nested bracket parsing in PEP508 marker parser. * Fix the sys_platform constants, which I noticed in bazel-contrib#2629 but they got also pointed out in bazel-contrib#2766. * Port some of python tests for requirement parsing and improve the implementation. Those tests will be removed in bazel-contrib#2629. * Move the platform related code to a separate file. * Rename `pep508_req.bzl` to `pep508_requirement.bzl` to follow the convention. All of the bug fixes have added tests. Work towards bazel-contrib#2423.
aignas
force-pushed
the
fix/starlark-env-marker
branch
from
f260d43 to
08f5114
Compare
rickeylev
approved these changes
Apr 10, 2025
| @@ -0,0 +1,57 @@ | |||
| # Copyright 2025 The Bazel Authors. All rights reserved. | |||
There was a problem hiding this comment.
FYI, going forward, we can omit these copyright headers
There was a problem hiding this comment.
Should we do with the old ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just bugfixes to already merged code:
also pointed out in fix: Resolve incorrect platform specific dependency #2766.
implementation. Those tests will be removed in refactor(pypi): translate wheel METADATA parsing to starlark #2629.
pep508_req.bzltopep508_requirement.bzlto follow theconvention.
All of the bug fixes have added tests.
Work towards #2423.