Establish minimum compatible Bazel, dep versions #1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, at this point I can't tell if the Windows breakage is a fluke or not. I can't reproduce it on my local Windows ARM64 VM because of Perhaps #1724 should land first (to add |
Separates the latest dependency versions that we test against from the minimum required versions and bumps `protobuf` to v30.2. Part of bazel-contrib#1482. Adds `scala/latest_deps.bzl` for `WORKSPACE` and `deps/latest` for Bzlmod, used by our internal test repos. Tests used to validate these dependency versions will land in a future change. Also: - Fixes a bug in the failure message of `_default_platform()` in `protoc_toolchains.bzl` by calling `string.join()` on the `HOST_CONSTRAINTS` list. - Downloads the `win64` build for Windows ARM64. --- This avoids forcing users to upgrade to the latest versions that `rules_scala` tests against. Inspired by a thread in the #bzlmod channel of the Bazel Slack workspace on 2025-01-01 indicating that rules should require the minumum versions possible: - https://bazelbuild.slack.com/archives/C014RARENH0/p1743597941149639 I didn't notice the `_default_platform()` error until building on Windows ARM64, since there's not yet a binary `protobuf` release for that platform. The `win64` workaround fixes the actual error, since Windows ARM64 can execute x86 and x64 binaries: - https://learn.microsoft.com/en-us/windows/arm/apps-on-arm-x86-emulation
mbland
force-pushed
the
minimum-dependency-versions
branch
from
0f5961c to
68ad128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separates the latest dependency versions that we test against from the minimum required versions and bumps
protobufto v30.2. Part of #1482.Adds
scala/latest_deps.bzlforWORKSPACEanddeps/latestfor Bzlmod, used by our internal test repos.Tests used to validate these dependency versions will land in a future change.
Also:
Fixes a bug in the failure message of
_default_platform()inprotoc_toolchains.bzlby callingstring.join()on theHOST_CONSTRAINTSlist.Downloads the
win64build for Windows ARM64.Motivation
This avoids forcing users to upgrade to the latest versions that
rules_scalatests against.Inspired by a thread in the #bzlmod channel of the Bazel Slack workspace on 2025-01-01 indicating that rules should require the minumum versions possible:
I didn't notice the
_default_platform()error until building on Windows ARM64, since there's not yet a binaryprotobufrelease for that platform. Thewin64workaround fixes the actual error, since Windows ARM64 can execute x86 and x64 binaries: