-
-
Notifications
You must be signed in to change notification settings - Fork 239
Implement latest requirements #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
helly25
wants to merge
19
commits into
bazel-contrib:master
Choose a base branch
from
helly25:feat/latest_requirements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+742
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2025
0c7f806
to
e95fc76
Compare
… them by common prefixes in the database we anyway have. Rather then forcing maintainers to enter more complex information this keeps us at simply adding the versions as generated from the hasher script.
…he use of the finder algorithm
Add the missing distributions starting with 18.1.8. Exclude old style windows distributions if new style ones are present as well.
Fix lint error.
Add a test for the distribution finder. The test computes what would be found given all versions a nd a combination of arch and os. Then the test compares the result to what is configured and shows the difference. If the difference is empty then the finder is correct. There are currently only deleted entries with the last deleted enty in version 18.1.0. In other words starting with llvm version 18.1.1 the finder is correct. That also means as long as this is true, when someone adds information for a new version then the test does not need to be updated.
This allows to specifically require ranges, including minimum and maximum versions as well as version exclusions. That can be easier than figuring out which versions are available for which platform. Further this allows to automatically pick up relevant versions automatically as they become available later.
…at is not setup correctly. Since it s going away there is also no point in adding and fixing it now.
Need to upgrade external helly25_bzl to 0.1.2 to fix its workspace file. Also important: Add the strip_prefix. Otherwise the workspaces dump the repo including the root directory. As a result the files cannot be found and BAzel only states there is no BUILD file. It should possibly suggest there is no such directory and no such bzl file in the first place.
* Nitpicking tweaks...
e37d81d
to
584e56c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #473
This supersedes PR #471
Instead of implementing a complex way of predicting the basename, find them by common prefixes in the database we anyway have.
Rather then forcing maintainers to enter more complex information this keeps us at simply adding the versions as generated from the hasher script.
This should also ultimately put #464 and any future occurrence to rest.
There is a new test that verifies which version cannot yet be found. That test shows that past 18.1.0 we can find all configured versions. Also the test shows that the main distribution types can all be found.
That allows support for
llvm_version = "latest"
which will effectively find the latest LLVM version. For many people this will be the easiest way to get started and solves the issue that not always all arch/os versions have been prepared for all LLVM versions. It also means you do not have to know whether the basename starts with "LLVM" or "clang_llvm", in which order arch and os have to be provided and how the os is exactly specified.We further add the ability to specify requirements, including minimum and maximum versions as well as version exclusions. That can be easier than figuring out which versions are available for which platform. Further this allows to automatically pick up relevant versions automatically as they become available later. Example:
The requirements strings mostly follow semver specs and support
<
,<=
,>
,>=
,==
and!=
. They only currently work for version componentsmajor
,minor
andpatch
. Since we do not list other versions in our config that is fine for now.This PR also adds information for a number of missing distributions.