Expose clang-apply-replacements filegroup in the distribution repo - #817
Open
jwendell wants to merge 2 commits into
Open
Expose clang-apply-replacements filegroup in the distribution repo#817jwendell wants to merge 2 commits into
clang-apply-replacements filegroup in the distribution repo#817jwendell wants to merge 2 commits into
Conversation
`clang-apply-replacements` shipped in the LLVM distribution and was already an aliased tool (`@llvm_toolchain//:clang-apply-replacements`), but unlike `clang-tidy` and `clang-format` it had no convenience filegroup in the distribution repo. Consumers wiring it up the way they wire `clang-tidy` -- via `@llvm_toolchain_llvm//:clang-tidy` -- hit a "no such target" error. Add the matching filegroup and a `build_test` covering all three tools. Signed-off-by: Jonh Wendell <jwendell@redhat.com>
jwendell
requested review from
dzbarsky,
fmeum,
helly25,
jsharpe and
rrbutani
as code owners
August 12, 2026 15:36
Author
|
/retest |
helly25
approved these changes
Aug 12, 2026
helly25
enabled auto-merge (squash)
August 12, 2026 23:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-apply-replacementsshipped in the LLVM distribution and was already an aliased tool (@llvm_toolchain//:clang-apply-replacements), but unlikeclang-tidyandclang-formatit had no convenience filegroup in the distribution repo. Consumers wiring it up the way they wireclang-tidy-- via@llvm_toolchain_llvm//:clang-tidy-- hit a "no such target" error.Add the matching filegroup and a
build_testcovering all three tools.