Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0] Move --fat_apk_cpu to the flag graveyard #24062

Merged
merged 2 commits into from
Oct 23, 2024
Merged

[8.0.0] Move --fat_apk_cpu to the flag graveyard #24062

merged 2 commits into from
Oct 23, 2024
+57 −46

Conversation

katre
Copy link
Member

@katre katre commented Oct 23, 2024

The flag is a no-op and has been removed from Bazel.

katre added 2 commits October 23, 2024 12:32
@katre
Stop using --fat_apk_cpu in tests.
9f29747 
PiperOrigin-RevId: 687111838
Change-Id: Ifb804d115aa0adec833287e67f44c519080c299b
@katre
Move deprecated flag --fat_apk_cpu to the graveyard.
dcfbdf6 
PiperOrigin-RevId: 688992744
Change-Id: I3d7f105fef11870c72504513bb8e491adad2909b
@katre katre requested a review from a team as a code owner October 23, 2024 16:44
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Oct 23, 2024
@katre katre requested a review from ahumesky October 23, 2024 17:25
@katre katre enabled auto-merge October 23, 2024 17:28
@iancha1992 iancha1992 added this to the 8.0.0 release blockers milestone Oct 23, 2024
@katre katre added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@katre katre added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@katre katre added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@katre katre added this pull request to the merge queue Oct 23, 2024
Merged via the queue into bazelbuild:release-8.0.0 with commit 1faeb68 Oct 23, 2024
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 23, 2024
@katre katre deleted the cp-android-flag-removal-8.x branch October 23, 2024 20:21
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 8.0.0 RC2. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=8.0.0rc2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahumesky ahumesky ahumesky approved these changes

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
8.0.0 release blockers
Development

Successfully merging this pull request may close these issues.
3 participants
@katre @iancha1992 @ahumesky