[8.1.0] Mark built-in providers as hashable #25230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Built-in providers always have an immutable `hashCode`. Making them hashable makes it easier to deduplicate a list of providers, which is sometimes required as the list of provider instances returned by a rule must not contain two instances for a given provider. Starlark-defined providers are already hashable, so this brings the behavior of built-in providers in line with them. Closes bazelbuild#24848. PiperOrigin-RevId: 724370319 Change-Id: I68147b1f707249a8b09ad170c5fc5b3da4776ccf
bazel-io
added
team-Remote-Exec
comius
approved these changes
Feb 11, 2025
Merged
via the queue into
bazelbuild:release-8.1.0
with commit Feb 11, 2025
3b0d75a
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built-in providers always have an immutable
hashCode. Making them hashable makes it easier to deduplicate a list of providers, which is sometimes required as the list of provider instances returned by a rule must not contain two instances for a given provider.Starlark-defined providers are already hashable, so this brings the behavior of built-in providers in line with them.
Closes #24848.
PiperOrigin-RevId: 724370319
Change-Id: I68147b1f707249a8b09ad170c5fc5b3da4776ccf
Commit c94a9bd