[8.1.0] Use Single.using instead of onError/onSuccess for async uploads
#25251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users have reported hangs in Bazel's asynchronous remote cache uploads that may be happening because neither `onSuccess` nor `onError` is called on the observer. Work towards bazelbuild#25232 Closes bazelbuild#25231. PiperOrigin-RevId: 725235495 Change-Id: I20c3aaa2ee57a52041dea0b3c17356445f2bbc34
bazel-io
added
team-Remote-Exec
Wyverald
approved these changes
Feb 11, 2025
Merged
via the queue into
bazelbuild:release-8.1.0
with commit Feb 11, 2025
cf3ebdf
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have reported hangs in Bazel's asynchronous remote cache uploads that may be happening because neither
onSuccessnoronErroris called on the observer.Work towards #25232
Closes #25231.
PiperOrigin-RevId: 725235495
Change-Id: I20c3aaa2ee57a52041dea0b3c17356445f2bbc34
Commit d4c9b92