Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Rust examples 8 - 9 #548

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

marvin-hansen
Copy link
Contributor

@marvin-hansen marvin-hansen commented Feb 2, 2025

Last batch of fixed up Rust examples.
Example 8 got a major makeover b/c the latest rules_rust separated into multiple sub-modules,
which required quite some refactoring.
Resolves #540

Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
# Conflicts:
#	rust-examples/02-hello-cross/MODULE.bazel
@meteorcloudy
Copy link
Member

The number of files for "07-deps-vendor" went up by a lot, is this absolutely necessary in the example?

@marvin-hansen
Copy link
Contributor Author

marvin-hansen commented Feb 3, 2025 via email

@marvin-hansen
Copy link
Contributor Author

marvin-hansen commented Feb 3, 2025 via email

@meteorcloudy
Copy link
Member

Bzlmod also offers a native vendor mode: https://bazel.build/external/vendor, not sure if it should be preferred.

@marvin-hansen
Copy link
Contributor Author

marvin-hansen commented Feb 3, 2025 via email

@meteorcloudy
Copy link
Member

I actually tried native bzlmod vendoring once and after having downloaded about 25GB of every Bazel rule for every platform under the sun

😅, I guess that's before we implemented vendoring targets? With https://bazel.build/external/vendor#vendor-target-dependencies, the Bzlmod vendor mode will only vendor dependencies required to build your targets for the current configuration, which should be much less dependencies than vendoring the whole world.

@marvin-hansen
Copy link
Contributor Author

marvin-hansen commented Feb 3, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bazel CI] Error in glob: glob pattern 'lib/clang/*/lib/**/*.dylib' didn't match anything
2 participants