Remove visionos_x86_64 support #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Apple released this without intel support, I think it's a good time to remove it
keith
requested review from
BalestraPatrick,
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
mattrobmattrob
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Some other references probably worth removing.
Docs mention:
rules_apple/apple/internal/visionos_rules.bzl
Line 1653 in 6ef5ca4
Test mention in this file and a handful of other files with similar mention:
|
Disabling auto-merge to make sure you see my comment before merging or taking it into account. |
|
nice finds, added |
luispadron
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Apple released this without intel support, I think it's a good
time to remove it