GRAD2-3315 : Changes to ignore school & district contact updates. #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumathi-thirumani
changed the title
sumathi-thirumani
changed the title
mightycox
reviewed
Feb 28, 2025
api/src/main/java/ca/bc/gov/educ/api/trax/service/EventHistoryService.java
Outdated
Show resolved
Hide resolved
cditcher
requested changes
Feb 28, 2025
There was a problem hiding this comment.
Hold up..... there's another way to do this. Each event type has it's own service that basically self determines if it should go into history table or not. For example DistrictContactUpdatedService/processEvent() calls this.updateEvent(eventEntity, true). Just changing the boolean to false will prevent it from being written to the history table. Reference: https://github.com/bcgov/EDUC-GRAD-TRAX-API/blob/main/api/src/main/java/ca/bc/gov/educ/api/trax/service/DistrictContactUpdatedService.java#L29
|
cditcher
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.