Merge pull request #2056 from bcgov/feature/ALCS-2321

Allow all but commissioner to archive cards

Author: trslater

alcs-frontend/src/app/features/board/dialogs/card-dialog/card-dialog.component.ts

@@ -52,7 +52,7 @@ export class CardDialogComponent implements OnInit, OnDestroy {
       this.canArchive =
         !!currentUser &&
         !!currentUser.client_roles &&
-        (currentUser.client_roles.includes(ROLES.ADMIN) || currentUser.client_roles.includes(ROLES.APP_SPECIALIST));
+        Object.values(ROLES).some((role) => role !== ROLES.COMMISSIONER && currentUser.client_roles?.includes(role));
     });
 
     this.dialog.backdropClick().subscribe(() => {

services/apps/alcs/src/common/authorization/roles.ts

@@ -18,7 +18,7 @@ export const ROLES_ALLOWED_APPLICATIONS = [
 ];
 
 export const ROLES_ALLOWED_BOARDS = ROLES_ALLOWED_APPLICATIONS;
-export const ROLES_ALLOWED_ARCHIVE = [AUTH_ROLE.ADMIN, AUTH_ROLE.APP_SPECIALIST];
+export const ROLES_ALLOWED_ARCHIVE = ROLES_ALLOWED_BOARDS;
 export const ANY_AUTH_ROLE = Object.values(AUTH_ROLE);
 export const ROLES_ALLOWED_SEARCH = [...ROLES_ALLOWED_APPLICATIONS, AUTH_ROLE.COMMISSIONER];
 export const ANY_ROLE_BUT_COMMISSIONER = Object.values(AUTH_ROLE).filter((role) => role !== AUTH_ROLE.COMMISSIONER);