ALCS-2227: Configure dependabot #2169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+25
to
+35
| run: | | ||
| # Get PR number from branch name | ||
| PR_NUMBER=$(echo ${{ github.event.workflow_run.head_branch }} | grep -o '[0-9]\+' || echo '') | ||
|
|
||
| if [ -n "$PR_NUMBER" ]; then | ||
| # Approve PR | ||
| gh pr review $PR_NUMBER --approve | ||
|
|
||
| # Enable auto-merge | ||
| gh pr merge $PR_NUMBER --auto --merge | ||
| fi |
Check failure
Code scanning / CodeQL
Expression injection in Actions Critical
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 13 days ago
To fix the problem, we need to avoid using the untrusted input value directly in the shell command. Instead, we should set the untrusted input value to an intermediate environment variable and then use the environment variable using the native syntax of the shell. This approach prevents the injection vulnerability by ensuring that the value is treated as a plain string rather than being interpreted as part of the shell command.
Specifically, we will:
- Set the
PR_NUMBERvalue to an environment variable. - Use the environment variable in the shell command.
Suggested changeset
1
.github/workflows/auto-merge-dependabot.yml
| @@ -24,5 +24,8 @@ | ||
| - name: Auto-merge Dependabot PR | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| HEAD_BRANCH: ${{ github.event.workflow_run.head_branch }} | ||
| run: | | ||
| # Get PR number from branch name | ||
| PR_NUMBER=$(echo ${{ github.event.workflow_run.head_branch }} | grep -o '[0-9]\+' || echo '') | ||
| PR_NUMBER=$(echo "$HEAD_BRANCH" | grep -o '[0-9]\+' || echo '') | ||
|
|
||
| @@ -30,8 +33,5 @@ | ||
| # Approve PR | ||
| gh pr review $PR_NUMBER --approve | ||
| gh pr review "$PR_NUMBER" --approve | ||
|
|
||
| # Enable auto-merge | ||
| gh pr merge $PR_NUMBER --auto --merge | ||
| fi | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| gh pr merge "$PR_NUMBER" --auto --merge |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.