Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALCS-2522: Make user email optional #2197

Merged
merged 4 commits into from
Mar 6, 2025
Merged

ALCS-2522: Make user email optional #2197

merged 4 commits into from
Mar 6, 2025

Conversation

trslater
Copy link
Collaborator

@trslater trslater commented Mar 6, 2025

  • Make user email column nullable
  • Make all user email DTO fields optional
  • Disable subtask email filtering when email absent
  • Check for email before sending new user request email

Abradat
Abradat previously approved these changes Mar 6, 2025
Copy link
Collaborator

@Abradat Abradat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trslater trslater changed the title ALCS-2522: Make user password optional ALCS-2522: Make user email optional Mar 6, 2025
trslater added 4 commits March 6, 2025 10:51
- Make user email column nullable
- Make all user email DTO fields optional
- Disable subtask email filtering when email absent
- Check for email before sending new user request email
Copy link

sonarqubecloud bot commented Mar 6, 2025

Copy link
Collaborator

@Abradat Abradat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trslater trslater merged commit dea7191 into develop Mar 6, 2025
7 checks passed
@trslater trslater deleted the feature/ALCS-2522 branch March 6, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants