Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALCS-2603: Fix move to top/bottom #2208

Merged
merged 2 commits into from
Mar 11, 2025
Merged

ALCS-2603: Fix move to top/bottom #2208

merged 2 commits into from
Mar 11, 2025

Conversation

trslater
Copy link
Collaborator

  • Ordering was relying on UUID which doesn't exist if conditions haven't been saved
  • Changed to use only order property, index not needed
  • Also simplified updating order and sorting

- Index not needed
- Simplify updating/sorting
Copy link
Collaborator

@Abradat Abradat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fbarreta fbarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trslater trslater merged commit 3011f07 into main Mar 11, 2025
8 checks passed
@trslater trslater deleted the hotfix/ALCS-2603 branch March 11, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants