Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALCS-2603 QA #1: Replace condition that kept sane order numbers #2210

Merged
merged 1 commit into from
Mar 11, 2025
Merged

ALCS-2603 QA #1: Replace condition that kept sane order numbers #2210

merged 1 commit into from
Mar 11, 2025

Conversation

trslater
Copy link
Collaborator

  • I had taken out a condition that I thought wasn't necessary, because it relied on the index which was causing the initial problem
  • The condition prevented conditions that didn't move from having their orders updated
  • I've put it back and it is now based on the record order, which should accomplish the same result

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Abradat
Abradat approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@Abradat Abradat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trslater trslater merged commit 26c3a88 into main Mar 11, 2025
8 checks passed
@trslater trslater deleted the hotfix/ALCS-2603-QA-1 branch March 11, 2025 23:14
@github-actions github-actions bot mentioned this pull request Mar 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abradat Abradat Abradat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trslater @Abradat