Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORV2 3400 GARMS integration and cash file changes #1849

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

ORV2 3400 GARMS integration and cash file changes #1849

wants to merge 37 commits into from

Conversation

gchauhan-aot
Copy link
Collaborator

@gchauhan-aot gchauhan-aot commented Mar 11, 2025 •
edited by github-actions bot
Loading

Description

This PR has the code to ;

  • Connect to eGARM system
  • Create and send file to eGARMS
  • LFTP installation to the conatiner: As the end system is Mainframe we need to add lftp to docker container to send file using ftps to the this system.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A : tested the connectivity and file format with GARMS team.
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

john-fletcher-aot and others added 30 commits February 20, 2025 16:55
@john-fletcher-aot
Initial draft of SQL to support GARMS transaction files
8522d45
@john-fletcher-aot
Include transaction from and to fields in garms file table
2490bde
@john-fletcher-aot
Rename SQL versions to v62 before merge main
dac6180
@john-fletcher-aot
Merge branch 'main' into ORV2-3402
b67c292
@john-fletcher-aot
Update README for new SQL file
b4eca46
@gchauhan-aot
Garms Cash file changes
30e1955
@gchauhan-aot
GARMS cash file changes
e3ae32c
@gchauhan-aot
Garms Cash file changes
e88b213
@gchauhan-aot
Garms cash File changes
5d48c44
@gchauhan-aot
send Garms file updates
53ca1cb
@gchauhan-aot
updating GARMS env variables
bc46a14
@gchauhan-aot
npm changes
fa2ff1d
@gchauhan-aot
adding logging
64fffdd
@gchauhan-aot
remove local file
b4b8101
@gchauhan-aot
updates to garms helper
0351458
@gchauhan-aot
update site LRecl seeting for mainframe
5d0f9e4
@gchauhan-aot
formatting
0184f46
@gchauhan-aot
Concatenate site & put command for LFTP
cc04294 
each ftps.raw command makes a new connection.
So send site settings and file in the same command.
It makes sure that site settings are persisted with put command.
@gchauhan-aot
adding type
da8f462
@gchauhan-aot
parameterize GARMS environment
b10f1ec
@gchauhan-aot
parameterizing garms environment values
6263368
@gchauhan-aot
updating docker configs for garms
059577c
@gchauhan-aot
Merge remote-tracking branch 'origin/main' into ORV2-3402
949efc5 
# Conflicts:
#	scheduler/Dockerfile
@gchauhan-aot
removing env vars from docker file
baa51de
@gchauhan-aot
updates to garms cash file
691862b
@gchauhan-aot
updating method call
4e5e1dc
@gchauhan-aot
updates to cash file :
1f6e116 
do not process if no data found
update agent number
@gchauhan-aot
formatting and check transaction instead of file
e5de60d
@gchauhan-aot
remove extra argument
bc9114b
@gchauhan-aot
updating transaction check
a067825
@gchauhan-aot gchauhan-aot added dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Mar 11, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 11, 2025
View reviewed changes
@gchauhan-aot
updating db script
01e3879 
to update service code and gl code locally
@gchauhan-aot
formatting
d9e41d4 
and handling no data to process scenario
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc_policy'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc dops'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc_scheduler'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc vehicles'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cberg-aot cberg-aot Awaiting requested review from cberg-aot cberg-aot is a code owner

@john-fletcher-aot john-fletcher-aot Awaiting requested review from john-fletcher-aot john-fletcher-aot is a code owner

@praju-aot praju-aot Awaiting requested review from praju-aot praju-aot is a code owner

@krishnan-aot krishnan-aot Awaiting requested review from krishnan-aot krishnan-aot is a code owner

@zgong-gov zgong-gov Awaiting requested review from zgong-gov zgong-gov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dont merge a branch for anything that shouldn't be merged (yet or ever) dont review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gchauhan-aot @john-fletcher-aot